Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loop validated cache #79
base: master
Are you sure you want to change the base?
Loop validated cache #79
Changes from 4 commits
951a67d
ada5ee8
602a0e1
36a2dbb
3cd4e57
c69f777
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a mutable singleton with some possible issues.
First, philosophically, why use a singleton here? It goes against the ISO guidelines, and the resulting behavior could instead be maintained in a local scope. E.g., a loop ID is maintained in the control loop and all
ValdatedLoopCache
s are constructed with a reference/pointer to that ID (and can use the same invalidation logic).That said, since this is a pretty high-level, integral thing, then a singleton could be fine. But:
LoopId
were to be referenced in another static variable initialization;loop_id_
can be arbitrarily modified by children ofLoopId
;LoopId
can be multiply constructed (which could be confusing).You could alleviate some of these issues by making
LoopId
a Meyer's Singleton. I think something like this would work.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the purpose of this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just placeholder making sure the new version is good. Could move implementation into it if that is something we want, but otherwise I will delete.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm always of the opinion that the implementation should live in the source file when possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is not templated, it's an easy move, so I will.