refactor sign_raw_tx error return

KomodoPlatform · Aug 24, 2023 · d678aba · d678aba
1 parent 69bb529
commit d678aba
Show file tree

Hide file tree

Showing 6 changed files with 13 additions and 18 deletions.
diff --git a/mm2src/coins/eth.rs b/mm2src/coins/eth.rs
@@ -1907,12 +1907,12 @@ impl MarketCoinOps for EthCoin {
         )
     }
 
+    /// Stub for sign utxo tx 
     #[inline(always)]
     async fn sign_raw_tx(&self, _args: &SignRawTransactionRequest) -> SignRawTransactionResult {
-        Err(RawTransactionError::NotImplemented {
+        MmError::err(RawTransactionError::NotImplemented {
             coin: self.ticker().to_string(),
-        }
-        .into())
+        })
     }
 
     fn wait_for_confirmations(&self, input: ConfirmPaymentInput) -> Box<dyn Future<Item = (), Error = String> + Send> {

diff --git a/mm2src/coins/lightning.rs b/mm2src/coins/lightning.rs
@@ -1098,10 +1098,9 @@ impl MarketCoinOps for LightningCoin {
 
     #[inline(always)]
     async fn sign_raw_tx(&self, _args: &SignRawTransactionRequest) -> SignRawTransactionResult {
-        Err(RawTransactionError::NotImplemented {
+        MmError::err(RawTransactionError::NotImplemented {
             coin: self.ticker().to_string(),
-        }
-        .into())
+        })
     }
 
     // Todo: Add waiting for confirmations logic for the case of if the channel is closed and the htlc can be claimed on-chain

diff --git a/mm2src/coins/solana.rs b/mm2src/coins/solana.rs
@@ -442,10 +442,9 @@ impl MarketCoinOps for SolanaCoin {
 
     #[inline(always)]
     async fn sign_raw_tx(&self, _args: &SignRawTransactionRequest) -> SignRawTransactionResult {
-        Err(RawTransactionError::NotImplemented {
+        MmError::err(RawTransactionError::NotImplemented {
             coin: self.ticker().to_string(),
-        }
-        .into())
+        })
     }
 
     fn wait_for_confirmations(&self, _input: ConfirmPaymentInput) -> Box<dyn Future<Item = (), Error = String> + Send> {

diff --git a/mm2src/coins/solana/spl.rs b/mm2src/coins/solana/spl.rs
@@ -270,10 +270,9 @@ impl MarketCoinOps for SplToken {
 
     #[inline(always)]
     async fn sign_raw_tx(&self, _args: &SignRawTransactionRequest) -> SignRawTransactionResult {
-        Err(RawTransactionError::NotImplemented {
+        MmError::err(RawTransactionError::NotImplemented {
             coin: self.ticker().to_string(),
-        }
-        .into())
+        })
     }
 
     fn wait_for_confirmations(&self, _input: ConfirmPaymentInput) -> Box<dyn Future<Item = (), Error = String> + Send> {

diff --git a/mm2src/coins/tendermint/tendermint_coin.rs b/mm2src/coins/tendermint/tendermint_coin.rs
@@ -2188,10 +2188,9 @@ impl MarketCoinOps for TendermintCoin {
 
     #[inline(always)]
     async fn sign_raw_tx(&self, _args: &SignRawTransactionRequest) -> SignRawTransactionResult {
-        Err(RawTransactionError::NotImplemented {
+        MmError::err(RawTransactionError::NotImplemented {
             coin: self.ticker().to_string(),
-        }
-        .into())
+        })
     }
 
     fn wait_for_confirmations(&self, input: ConfirmPaymentInput) -> Box<dyn Future<Item = (), Error = String> + Send> {

diff --git a/mm2src/coins/tendermint/tendermint_token.rs b/mm2src/coins/tendermint/tendermint_token.rs
@@ -541,10 +541,9 @@ impl MarketCoinOps for TendermintToken {
 
     #[inline(always)]
     async fn sign_raw_tx(&self, _args: &SignRawTransactionRequest) -> SignRawTransactionResult {
-        Err(RawTransactionError::NotImplemented {
+        MmError::err(RawTransactionError::NotImplemented {
             coin: self.ticker().to_string(),
-        }
-        .into())
+        })
     }
 
     fn wait_for_confirmations(&self, input: ConfirmPaymentInput) -> Box<dyn Future<Item = (), Error = String> + Send> {