-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MakerPaymentRefundFailed for BCH with bad-txns-nonfinal
#544
Comments
I have another such error, also with BCH
|
i have another
calling |
had a couple of
calling this is the complete json of such a swap happens on HUSH too
|
i can't recover any of the above funds... some of them are 3 days old, so waiting does not seem to help |
The bug appeared during refactoring, function sending maker refund transaction is using final sequence so locktime is ignored by coin daemon. Will fix asap. |
Should be fixed now, I've added the integration test covering this case so it will never happen again. Could you please update and retry recovering your KMD? Please keep this issue open afterwards because it's also related to another problem. |
that was fast :-)
|
TakerPaymentRefundFailed on BTC with same
https://pastebin.com/raw/7as9iQ2L calling |
Had a lot more of this errors in the last month... many with OOT, but also the usual ones with BCH... eg:
is this also dependant on the number of blocks mined between swap start and swap end/failed or recover_funds_of_swap call? OOT chain is not really active, so very few blocks there... if i make some blocks (by sending out txs, because on-demand-mining), i can also recover the funds, the recover_funds_of_swap works then... wonder if this also applies to BCH... |
Hi, I guess the reason is MM2 sets locktime as
But this doesn't work sometimes as MTP can be behind |
this
if i do some transactions and advance the chain, the MakerPaymentRefund works |
@cipig I have not implemented the mentioned change yet, the task got lost in a flow. I have scheduled it for next week. |
@cipig Could you please test the refunds on https://github.com/KomodoPlatform/atomicDEX-API/tree/mm2.1-fix-refund-non-final branch? If you need help to trigger a refund condition please let me know.
It is still a big problem for non-advancing (on-demand) chains because median time past is not advancing as well.
6 blocks with |
tested with BCH and it works fine... had 2 BCH refunds that were failing
after update both were refunded correctly
|
@cipig Thanks for testing! Could you please also start a new BCH swap and force a refund for it? We need to be sure that MM2 now correctly waits for MTP to advance during the swap. |
looks good... i killed mm2 on taker after MakerPayment (BCH) was sent and the refund on maker worked without error automatically on the specified time console on maker
JSON
|
@cipig Thanks a lot for testing! |
The MakerPaymentRefund of a interrupted swap failed
The reason the swap failed initially was that the Taker apparently stopped his node in the middle of the swap. The initial MakerPayment took 1.5h because there was no new block during that time on the BCH chain (Tx was confirmed in the first block that came after that gap).
This is the entire swap log:
ab40f146-ec98-497f-8e8e-d38c78b4361b.txt
After calling
curl --url "http://127.0.0.1:7783" --data "{\"userpass\":\"$userpass\",\"method\":\"recover_funds_of_swap\",\"params\":{\"uuid\":\"ab40f146-ec98-497f-8e8e-d38c78b4361b\"}}" | json_pp
the failed MakerPaymentRefund was sent out:The text was updated successfully, but these errors were encountered: