Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow passing dbdir and userhome as cmd arguments and support non-utf8 chars in these paths. #773

Closed
artemii235 opened this issue Dec 13, 2020 · 2 comments
Closed

Allow passing dbdir and userhome as cmd arguments and support non-utf8 chars in these paths. #773

artemii235 opened this issue Dec 13, 2020 · 2 comments
Assignees
@artemii235
Labels
bug Something isn't working

Comments

@artemii235
Copy link
Member

No description provided.

@artemii235 artemii235 self-assigned this Dec 17, 2020
@artemii235 artemii235 added the bug Something isn't working label Dec 17, 2020
artemii235 added a commit that referenced this issue Dec 17, 2020
@artemii235
Remove the last pieces of C code. Remove CMake from Readme. #773
ec928bb 
Remove files related to CMake too.
@artemii235
Copy link
Member Author

It turns out that we don't need such refactoring. The problem was in the OS_ensure_directory C function which was processing some characters incorrectly at least on Windows. The fix is pushed already, I will give it a try soon.

@artemii235 artemii235 mentioned this issue Dec 17, 2020
Merged
artemii235 added a commit that referenced this issue Dec 29, 2020
@artemii235
Remove C code completely. Refactor ordermatching logs. #773 #767 (#776)
7b510fb 
* Remove the last pieces of C code. Remove CMake from Readme. #773
Remove files related to CMake too.

* Remove the unnecessary windows build scripts and CI configs.

* Remove the marketmaker_build_depends.cmd.

* Remove CMakeLists.txt.
@artemii235
Copy link
Member Author

The fix worked out, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@artemii235 artemii235

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@artemii235