Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the UTXO fee to spend other payment to trade_preimage response. #872

Closed
artemii235 opened this issue Mar 22, 2021 · 1 comment
Closed

Add the UTXO fee to spend other payment to trade_preimage response. #872

artemii235 opened this issue Mar 22, 2021 · 1 comment
Assignees
@artemii235
Labels
enhancement New feature or request P1

Comments

@artemii235
Copy link
Member

As of now, we don't display the UTXO miner fee that is required to spend other side payments. It can lead to a very unsurprising outcome in case the fee is a significant portion of the volume. E.g. in the case of a 2.5 DOGE trade, the taker will receive only 1.5 DOGE due to 1 DOGE miner fee. We should add this fee to the response and display it in GUIs for 100% transparency.
@artemii235 artemii235 added enhancement New feature or request P1 labels Mar 22, 2021
@artemii235 artemii235 self-assigned this Mar 22, 2021
@artemii235 artemii235 mentioned this issue Mar 29, 2021
Merged
artemii235 added a commit that referenced this issue Mar 31, 2021
@artemii235
orderbook and trade_preimage RPC improvements #859 #872 (#883)
5c864f5 
* WIP.

* WIP.

* WIP.

* WIP and fix clippy.

* Refactor and fix clippy.

* WIP. Adding the UTXO fee to spend other payment to trade_preimage.

* WIP. Refactor tests.

* Finalize trade_preimage changes and refactor tests.

* Add paid_from_trading_vol to SavedTradeFee and refactor.

* Fix WASM tests compilation.

* Add separate TotalTradeFee struct for total_fees.

* Set QTUM/QRC20 mature_confirmations to 2000.
@artemii235
Copy link
Member Author

Done, docs are updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@artemii235 artemii235

Labels
enhancement New feature or request P1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@artemii235