Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[r2r] fix nonce_lock problem #1306

Merged
merged 26 commits into from
Jun 9, 2022
Merged

[r2r] fix nonce_lock problem #1306

merged 26 commits into from
Jun 9, 2022

Conversation

laruh
Copy link
Member

@laruh laruh commented Jun 8, 2022

Implementation of the feature from comments #1293

We can use a nonce lock shared between tokens using the same platform coin and the platform itself.
For example, ETH/USDT-ERC20 should use the same lock, but it will be different for BNB/USDT-BEP20.

Notes about manual installation of cargo-deny and udeps were added in Contributing guidelines.

@laruh laruh requested a review from onur-ozkan June 9, 2022 07:44
Copy link
Member

@onur-ozkan onur-ozkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Just one simple question. Other than that looks good to me!

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
Copy link
Member

@onur-ozkan onur-ozkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work 🔥

@artemii235 artemii235 merged commit faef87b into dev Jun 9, 2022
@artemii235 artemii235 deleted the nonce_lock_fix branch June 9, 2022 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants