[r2r] Allow bestorders RPC execution with number

[laruh]

Implementation of the code to solve the problem "Allow bestorders RPC execution without volume argument" #1314

Changes have been made:
1.best_orders.rs
Function process_best_orders_p2p_request_by_number was added
In fn best_orders_rpc_v2 instead of req: BestOrdersRequest there is req: BestOrdersRequestV2

2.lp_ordermatch.rs
OrdermatchRequest::BestOrdersByNumber was added, it is matched in function process_peer_request, result goes into the function best_orders::process_best_orders_p2p_request_by_number

3.tests added in best_orders_tests

[artemii235]

Good work! I have only one note for now :)

[yurii-khi]

Thanks @laruh for prompt fixes!
If I understand correctly from code, second approach, mentioned here #1314 (comment) was implemented eventually?

[laruh]

Thanks @laruh for prompt fixes! If I understand correctly from code, second approach, mentioned here #1314 (comment) was implemented eventually?

Hi!
That is correct. Currently program in bestorders_by_number branch implements the second variant of request

{
        "userpass": mm_alice.userpass,
        "method": "best_orders",
        "mmrpc": "2.0",
        "params": {
            "coin": "RICK",
            "action": "buy",
            "request_by": {
                "type": "number",
                "value": 1
            }
        }
    }

[artemii235]

@ozkanonur Could you take a look too, please? 🙂

[onur-ozkan]

LGTM. Great work 🔥

Only one note. In the codeblocks, I suggest you to not create permament mutable variables to avoid future bugs or unexpected issues behaviour. I prefer to create mut variables as temporary by shadowing them as immutable right after where I no longer need to update them.

An example:

@@ -191,6 +191,12 @@ pub fn process_best_orders_p2p_request_by_number(
             BestOrdersAction::Sell => result.insert(pair.0, best_orders),
         };
     }
+
+    // Drop mutability of result, protocol_infos and conf_infos
+    let result = result;
+    let protocol_infos = protocol_infos;
+    let conf_infos = conf_infos;
+
     let response = BestOrdersP2PRes {
         orders: result,
         protocol_infos,

[laruh]

LGTM. Great work fire

Only one note. In the codeblocks, I suggest you to not create permament mutable variables to avoid future bugs or unexpected issues behaviour. I prefer to create mut variables as temporary by shadowing them as immutable right after where I no longer need to update them.

An example:

@@ -191,6 +191,12 @@ pub fn process_best_orders_p2p_request_by_number(
             BestOrdersAction::Sell => result.insert(pair.0, best_orders),
         };
     }
+
+    // Drop mutability of result, protocol_infos and conf_infos
+    let result = result;
+    let protocol_infos = protocol_infos;
+    let conf_infos = conf_infos;
+
     let response = BestOrdersP2PRes {
         orders: result,
         protocol_infos,

Good idea! Done

[onur-ozkan]

🔥

[artemii235]

👍