[r2r] hotfix: disallow withdraw to taproot addresses #1503
Conversation
shamardy
changed the title
| if payload.is_empty() { | ||
| return Err(Error::EmptyBech32Payload); | ||
| } | ||
| if variant == bech32::Variant::Bech32m { |
There was a problem hiding this comment.
If the new variant is added, it will pass this check and the address will be parsed incorrectly. Please add an explicit match statement here without _ placeholder. We should get a compiler error when a new variant appears.
|
Tested in GUI for both BTC and tBTC, appears to be functioning as expected 👍 Thanks for the quick fix! |
shamardy
changed the title
shamardy
changed the title
|
@artemii235 @caglaryucekaya @sergeyboyko0791 this is ready for another review round. |
|
Unstable ETH tests have been fixed in |
@sergeyboyko0791, yes, I think it's worth doing it. @shamardy |
shamardy
changed the title
… bip-0173 but invalidated by bip-0350
shamardy
changed the title
|
|
||
| #[test] | ||
| // https://github.com/bitcoin/bips/blob/master/bip-0173.mediawiki#test-vectors | ||
| fn test_invalid_segwit_addresses() { |
There was a problem hiding this comment.
You skipped the first test, Invalid human-readable part
There was a problem hiding this comment.
it's covered here https://github.com/KomodoPlatform/atomicDEX-API/blob/d950555d2d78a42e40c3e59a4deb3963894dd91d/mm2src/mm2_main/src/mm2_tests.rs#L1688 We check the hrp against the hrp from coin config outside the from_str function since the hrp from config can't be passed to from_str
So this address tc1qw508d6qejxtdg4y5r3zarvary0c5xw7kg3g4ty from the test vectors when converted to SegwitAddress using from_str will be valid
There was a problem hiding this comment.
This is where the comparison happens https://github.com/KomodoPlatform/atomicDEX-API/blob/d950555d2d78a42e40c3e59a4deb3963894dd91d/mm2src/coins/utxo/utxo_common.rs#L3815-L3822
No description provided.