Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(restrictions): remove wallet-only restriction from max_maker_vol #2153

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

onur-ozkan
Copy link
Member

max_maker_vol RPC is actively used by client applications and does not rely on swap operations. This change allows wallet-only mode assets to use max_maker_vol RPC.

Signed-off-by: onur-ozkan <work@onurozkan.dev>
@onur-ozkan onur-ozkan changed the title fix(incorrect-restriction): remove wallet-only restriction from max maker volume fix(incorrect-restriction): remove wallet-only restriction from max_maker_vol Jul 2, 2024
@onur-ozkan onur-ozkan changed the title fix(incorrect-restriction): remove wallet-only restriction from max_maker_vol fix(restrictions): remove wallet-only restriction from max_maker_vol Jul 2, 2024
Signed-off-by: onur-ozkan <work@onurozkan.dev>
Copy link
Collaborator

@mariocynicys mariocynicys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@shamardy shamardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I see no problem with allowing this to work with wallet only coins since there are other restrictions in place for the order placing methods.

@shamardy shamardy merged commit 1d39a91 into dev Jul 2, 2024
21 of 25 checks passed
@shamardy shamardy deleted the wallet-only-restriction branch July 2, 2024 21:14
dimxy added a commit that referenced this pull request Jul 3, 2024
* dev:
  fix(restrictions): remove wallet-only restriction from max_maker_vol (#2153)
  feat(tendermint): support unsigned txs for ledger's keplr extension (#2148)
  chore(toolchain): upgrade to 1.72 nightly (#2149)
  feat(solana-swap): solana swap protocol v1 POC (#2091)
  fix(docs): update cargo test command (#2144)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants