Skip to content

Commit

Permalink
Add HERO12 Black support
Browse files Browse the repository at this point in the history
  • Loading branch information
KonradIT committed Sep 6, 2023
1 parent 6140b1d commit f9b39f5
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ Right now the script supports these cameras:
- HERO2 - HERO5
- MAX
- Fusion
- HERO6 - HERO11
- HERO6 - HERO12
- Insta360: X2, GO2, X3
- DJI: Osmo Pocket 1/2, DJI Osmo Action 1/2/3, Mavics, Minis
- Android: All, but with Pixel 6 (Google Camera) specific fixes
Expand Down
2 changes: 1 addition & 1 deletion pkg/gopro/connect.go
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ func ImportConnect(params utils.ImportParams) (*utils.Result, error) {
root := strings.Split(gpInfo.Info.FirmwareVersion, ".")[0]

switch root {
case "HD9", "H21", "H22":
case "HD9", "H21", "H22", "H23":
verType = V2
gpTurbo = true
case "HD6", "HD7", "HD8":
Expand Down
4 changes: 2 additions & 2 deletions pkg/gopro/gopro.go
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ func (Entrypoint) Import(params utils.ImportParams) (*utils.Result, error) {
params.Input = filepath.Join(params.Input, fmt.Sprint(DCIM))

switch root {
case "HD6", "HD7", "HD8", "H19", "HD9", "H21", "H22":
case "HD6", "HD7", "HD8", "H19", "HD9", "H21", "H22", "H23":
result := importFromGoProV2(params)
return &result, nil
case "HD2", "HD3", "HD4", "HX", "HD5":
Expand Down Expand Up @@ -533,7 +533,7 @@ func cleanVersion(s string) string {
i := strings.LastIndex(s, ",")
excludingLast := s[:i] + strings.Replace(s[i:], ",", "", 1)

if strings.Contains(s, "HERO10") || strings.Contains(s, "HERO11") {
if strings.Contains(s, `,"firmware version"`) {
return strings.ReplaceAll(s, "\n", "")
}
return excludingLast
Expand Down

0 comments on commit f9b39f5

Please sign in to comment.