Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Styles feedback #1529

Merged
merged 1 commit into from
Oct 8, 2020
Merged

Styles feedback #1529

merged 1 commit into from
Oct 8, 2020

Conversation

MarcinAman
Copy link
Contributor

@MarcinAman MarcinAman commented Oct 2, 2020 •
edited
Loading

Since i am waiting for the designer's answer i'd like to merge this PR and fix create another one with his feedback.

Notable changes:

  • description is below signature
  • left navigation filter doesn't eagerly show results for empty input
  • full documentation is rendered only on dedicated pages, on other only brief is rendered

@MarcinAman MarcinAman force-pushed the styles-feedback branch 5 times, most recently from a8823c5 to 9159d4d Compare October 5, 2020 15:57
@MarcinAman MarcinAman marked this pull request as ready for review October 5, 2020 16:02
@MarcinAman MarcinAman force-pushed the styles-feedback branch 2 times, most recently from 1fb0f51 to b3e0012 Compare October 7, 2020 12:40
@MarcinAman MarcinAman linked an issue Oct 8, 2020 that may be closed by this pull request
Feedback: Package page #1337
Closed
@kamildoleglo kamildoleglo merged commit 68553bf into master Oct 8, 2020
@kamildoleglo kamildoleglo deleted the styles-feedback branch October 8, 2020 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamildoleglo kamildoleglo kamildoleglo approved these changes

@sellophane sellophane Awaiting requested review from sellophane

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feedback: Package page
2 participants
@MarcinAman @kamildoleglo