Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JvmOverloads #1712

Merged
merged 3 commits into from
Feb 4, 2021
Merged

JvmOverloads #1712

merged 3 commits into from
Feb 4, 2021

Conversation

bishiboosh
Copy link
Contributor

@bishiboosh bishiboosh commented Jan 27, 2021

This feature adds JvmOverloads support by generating the required functions.

As DFunction.asJava was modified, I took the liberty of also fixing the fact that top-level functions weren't marked as static.

@bishiboosh
Copy link
Contributor Author

(cc @MarcinAman, this is the first PR, I'll try to do the JvmSynthetic one tomorrow)

Copy link
Contributor

@kamildoleglo kamildoleglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR, thanks! Just a few minor comments

@MarcinAman MarcinAman merged commit 47682ae into Kotlin:master Feb 4, 2021
@MarcinAman
Copy link
Contributor

Thanks ☺️

@bishiboosh bishiboosh deleted the feature/jvm-overload branch February 4, 2021 07:21
This was referenced Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants