Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes "The following documentation URLs were checked" message in Android Studio (IntelliJ) #2734

Merged
merged 2 commits into from
Nov 9, 2022

Conversation

bomberaya
Copy link
Contributor

@bomberaya bomberaya commented Nov 1, 2022

Fixed wrong Javadoc links in Android Studio (IntelliJ)

Before:
Screen Shot 2022-11-01 at 23 27 52

After:
Screen Shot 2022-11-02 at 00 03 20


Fixed missing package name in rendered html pages

Before:
Screen Shot 2022-11-01 at 23 56 33 2

After:
Screen Shot 2022-11-01 at 23 56 33

@IgnatBeresnev IgnatBeresnev self-requested a review November 2, 2022 07:43
@IgnatBeresnev
Copy link
Member

Sweet, thanks for fixing it! People have been frustrated with the IntelliJ integration for a long time, so it's much appreciated

Can you please have a look at the failing test and see if there are any other?

JavadocLocationTest > resolved signature to one argument function() FAILED

@bomberaya
Copy link
Contributor Author

You're welcome :) Is there already an open issue for this?

I will fix the tests as well in a couple of days.

@IgnatBeresnev
Copy link
Member

IgnatBeresnev commented Nov 9, 2022

Is there already an open issue for this?

I don't think this particular problem has been reported, but there's an umbrella issue #215

You'll probably find more bugs as you continue using it 😅 I think the integration has not been tested properly and the format was developed mostly based on the visuals. Reporting such bugs and especially fixing them would be much appreciated!

Copy link
Member

@IgnatBeresnev IgnatBeresnev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@IgnatBeresnev IgnatBeresnev merged commit 6319343 into Kotlin:master Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants