Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default logging level of console apps #2871

Merged
merged 1 commit into from
Feb 20, 2023

Conversation

IgnatBeresnev
Copy link
Member

@IgnatBeresnev IgnatBeresnev commented Feb 16, 2023

This is a prerequisite / enabler for #2873

  • Changed the default logging level of the CLI runner configuration (DEBUG -> PROGRESS)
  • Changed the default logging level of DokkaConsoleLogger (DEBUG -> PROGRESS)
  • Preserved the DEBUG level in public test API declarations
  • Changed our tests that created DokkaConsoleLogger to create it with the DEBUG level as before, in case it was important

I don't think DEBUG is a reasonable default value for any logger. It can leak sensitive and excessive information. Luckily, this is easily configurable, so it should not cause migration problems if it affects any users/plugins.

Dokka itself emits only one log message with the debug level:

logger.debug(
"Conflicting documentation for ${DRI.from(element)}" +
"${superMethods.map { DRI.from(it) }}"
)

@IgnatBeresnev IgnatBeresnev merged commit dbff38b into master Feb 20, 2023
@IgnatBeresnev IgnatBeresnev deleted the change-console-logging-level branch February 20, 2023 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants