-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move the Properties block to be above Functions #2908
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -90,17 +90,17 @@ open class HtmlRenderer( | |
listOf( | ||
BasicTabbedContentType.CONSTRUCTOR, | ||
BasicTabbedContentType.TYPE, | ||
BasicTabbedContentType.FUNCTION, | ||
BasicTabbedContentType.PROPERTY | ||
BasicTabbedContentType.PROPERTY, | ||
BasicTabbedContentType.FUNCTION | ||
) | ||
), | ||
if (extensions.isEmpty()) null else ContentTab( | ||
"Members & Extensions", | ||
listOf( | ||
BasicTabbedContentType.CONSTRUCTOR, | ||
BasicTabbedContentType.TYPE, | ||
BasicTabbedContentType.FUNCTION, | ||
BasicTabbedContentType.PROPERTY, | ||
BasicTabbedContentType.FUNCTION, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Would be nice to drop a comment about the order's meaning and why the order is the way it is There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Unfortunately, here the order doesn't make any difference, even though I expected it would :( Here it's purely cosmetic and I made the change for consistency. Something tells me leaving a comment like that here could be confusing down the road.. I'll write the tests for the true order though |
||
BasicTabbedContentType.EXTENSION_PROPERTY, | ||
BasicTabbedContentType.EXTENSION_FUNCTION | ||
) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing the order here doesn't actually do anything, so it's just for consistency