Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move POM config to maven-publish convention plugin #2946

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

aSemy
Copy link
Contributor

@aSemy aSemy commented Mar 28, 2023

infrastructure Everything related to builds tools, CI configurations and project tooling

Continue migrating the build logic to use convention plugins #2703

It is a small part of simplifying the logic in build-logic/src/main/kotlin/org/jetbrains/publication.kt

Impact

This change has only one change: I removed the afterEvaluate {} logic for configuring the Dokka Gradle Plugin POM. The result is that the POM is now different.

image

(the PR is on the left, master is on the right)

I'd like to be able to avoid this, but I think that improving the build logic is better than trying to edit a POM that most people won't realise even exists!

Testing

I have tested this by

  1. update dokka_version to be 1.8.20 (just so long as it's not a SNAPSHOT - otherwise the comparison below is impossible)
  2. publishing to MavenProjectLocal
    ./gradlew publishAllPublicationsToMavenProjectLocalRepository
  3. rename $rootDir/build/maven-project-local to $rootDir/build/maven-project-local-tmp
  4. checking out master branch
  5. re-run
    ./gradlew publishAllPublicationsToMavenProjectLocalRepository
  6. comparing (with IntelliJ) $rootDir/build/maven-project-local with $rootDir/build/maven-project-local-tmp

@IgnatBeresnev IgnatBeresnev self-requested a review March 29, 2023 18:37
Copy link
Member

@IgnatBeresnev IgnatBeresnev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thank you! 👍

Pretty sure it's going to be OK, but I've triggered lengthy integration tests just in case, can be merged once they pass

@IgnatBeresnev IgnatBeresnev merged commit 2b73ddd into Kotlin:master Mar 30, 2023
@aSemy aSemy deleted the feat/update_pom_config branch March 30, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants