Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor fix for document #2979

Merged
merged 2 commits into from
Apr 26, 2023
Merged

minor fix for document #2979

merged 2 commits into from
Apr 26, 2023

Conversation

LiYing2010
Copy link
Contributor

@LiYing2010 LiYing2010 commented Apr 24, 2023

Change List

minor fix for documents: typo, code style

Copy link
Member

@IgnatBeresnev IgnatBeresnev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, thanks for fixing a bunch of small inconsistencies, I would've never noticed these!

docs/topics/dokka-plugins.md Outdated Show resolved Hide resolved
docs/topics/dokka-plugins.md Outdated Show resolved Hide resolved
@LiYing2010
Copy link
Contributor Author

@IgnatBeresnev

I have reverted changes for idents,
but there are 2 commits in this PR now,
do you want me rebase and force-push this PR, so I can make the commit history more beautiful?

@IgnatBeresnev
Copy link
Member

Once again, thank you! 👍 👍

I have reverted changes for idents,
but there are 2 commits in this PR now,
do you want me rebase and force-push this PR, so I can make the commit history more beautiful?

We use GitHub's "Squash and merge", so there will be a single merge commit anyway, no need to do anything yourself, but thanks for asking and willing to do it :)

@IgnatBeresnev IgnatBeresnev merged commit 1632ff3 into Kotlin:master Apr 26, 2023
@LiYing2010 LiYing2010 deleted the fix_doc branch April 27, 2023 04:19
@LiYing2010
Copy link
Contributor Author

Thank you
I am glad I can help a little

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants