Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility: add outline when section-tab is focused #3416

Merged
merged 3 commits into from
Apr 16, 2024

Conversation

lauzadis
Copy link
Contributor

Adds an outline to section-tabs when they are focused. The color matches the underline color when they are hovered over.

Solves violation number 4 in this issue: #3414

Copy link
Contributor

@berezinant berezinant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lauzadis, this improvement is useful 👍

I've only noticed that there are two types of tabs so could you please add the fix for platform-bookmark as well?

image

lauzadis and others added 2 commits April 12, 2024 15:34
Co-authored-by: Anton Berezin <berezinant@gmail.com>
@lauzadis
Copy link
Contributor Author

I took your suggestion about focus-visible selector and expanded the fix to cover platform-bookmark. Thanks!

@berezinant berezinant merged commit ff4c2d0 into Kotlin:master Apr 16, 2024
6 checks passed
@lauzadis lauzadis deleted the accessibility-visual-focus branch April 17, 2024 13:53
@IgnatBeresnev IgnatBeresnev added this to the Dokka 2.0.0 milestone Apr 25, 2024
@IgnatBeresnev IgnatBeresnev added the format: html An issue/PR related to Dokka's default HTML output format label Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
format: html An issue/PR related to Dokka's default HTML output format
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants