Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add stable hashCode() calculation to PrimitiveSerialDescriptor #2136

Merged
merged 3 commits into from
Dec 29, 2022
Merged

Add stable hashCode() calculation to PrimitiveSerialDescriptor #2136

merged 3 commits into from
Dec 29, 2022

Conversation

vgv
Copy link
Contributor

@vgv vgv commented Dec 22, 2022

Fix #2135

@sandwwraith
Copy link
Member

You're right; all descriptors should have meaningful equals. Can you please also add a test?

@sandwwraith sandwwraith self-requested a review December 22, 2022 13:11
@vgv
Copy link
Contributor Author

vgv commented Dec 23, 2022

I've added tests

sandwwraith
sandwwraith requested changes Dec 27, 2022
View reviewed changes
Copy link
Member

@sandwwraith sandwwraith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Just move tests out of internal package, please

core/commonTest/src/kotlinx/serialization/internal/PrimitiveSerialDescriptorTest.kt Outdated Show resolved Hide resolved
@vgv vgv requested a review from sandwwraith December 29, 2022 14:07
@sandwwraith sandwwraith merged commit 3310495 into Kotlin:master Dec 29, 2022
sandwwraith pushed a commit that referenced this pull request Jan 3, 2023
@vgv @sandwwraith
Add stable hashCode()/equals() calculation to PrimitiveSerialDescript…
04e0983 
…or (#2136)

Fixes #2135

(cherry picked from commit 3310495)
@sandwwraith
Copy link
Member

This should have been opened against dev, but I haven't noticed :( Cherry-picked from master to dev manually.

@qwwdfsad
Copy link
Collaborator

qwwdfsad commented Jan 3, 2023

It's better to merge master into dev instead to avoid duplicate commits while still being in the same repository state eventually

@vgv vgv deleted the issue-2135 branch May 18, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandwwraith sandwwraith sandwwraith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make PrimitiveSerialDescriptor.hashCode() stable
3 participants
@vgv @sandwwraith @qwwdfsad