Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed HOCON publication #2723

Merged
merged 3 commits into from
Jun 24, 2024
Merged

Fixed HOCON publication #2723

merged 3 commits into from
Jun 24, 2024

Conversation

shanshin
Copy link
Contributor

Fixes #2717

sandwwraith
sandwwraith reviewed Jun 20, 2024
View reviewed changes
Copy link
Member

@sandwwraith sandwwraith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also pls add dependency on Hocon module to integration-test

build.gradle.kts Outdated
repositories.from(testRepositories)
}

abstract class ArtifactsCheckTask: DefaultTask() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be in a separate file rather than in build.gradle.kts

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, perhaps we can move artifacts.txt from root folder to gradle or something

@shanshin shanshin merged commit 3de98ff into dev Jun 24, 2024
4 checks passed
@shanshin shanshin deleted the fix-publication branch June 24, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandwwraith sandwwraith sandwwraith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shanshin @sandwwraith