fix crash when repl.mistate is defined but nothing #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't really understand the change that was made as I didn't look into it, but suffice it to say it's possible for
repl.mistateto be defined butnothing. In such a case it doesn't have the fieldinterfaceand so OhMyREPL crashes on the next line. This adds a check for whether that field isnothingand does whatever it would do if it weren't defined. Not 100% confident this is the intended behavior but seems to work fine. I suspect that theisdefined(repl,:mistate)can be removed entirely, but I really don't know, so I left it in.