Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrading the XUnit version being used in the src project #10

Merged
merged 1 commit into from
Jan 21, 2023

Conversation

Kritner
Copy link
Member

@Kritner Kritner commented Jan 21, 2023

Description

  • Was having issues with some of the XUnit assert changes (seemingly) introduced in the most recent version of XUnit
  • Looks like targeting the lower version of XUnit shouldn't impact the functionality of this package, and will be more accessible to additional consumers.

Fixes # (issue number)

Type of Change

Use an x in between the [ ] for each line applicable to the type of change for this PR

  • Bug fix
  • New Feature
  • Documentation
  • Code improvement
  • Breaking change - if a public API changes, or any change that DOES or MAY require a major revision to the NuGet package version due to semver.
  • Unit tests
  • Code samples
  • Added your repository URL to the readme because you make use of this super cool package! ;)
  • Other

Changes the XUnit dependency from 2.4.2 to 2.4.0

Checklist

* Was having issues with some of the XUnit assert changes (seemingly) introduced in the most recent version of XUnit
* Looks like targeting the lower version of XUnit shouldn't impact the functionality of this package, and will be more accessible to additional consumers.
@Kritner Kritner added the enhancement New feature or request label Jan 21, 2023
@Kritner Kritner merged commit a23a9ee into main Jan 21, 2023
@Kritner Kritner deleted the feature/downgradeXunitVersion branch January 21, 2023 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant