Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflow: pin yq version to v4.34.2 #89

Merged
merged 1 commit into from
Aug 11, 2023
Merged

Conversation

KevFan
Copy link
Contributor

@KevFan KevFan commented Aug 11, 2023

Resolves #88

@KevFan KevFan added kind/bug Something isn't working participation/good first issue Good for newcomers size/small labels Aug 11, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2023

Codecov Report

Merging #89 (15f5fae) into main (5381563) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #89   +/-   ##
=======================================
  Coverage   43.31%   43.31%           
=======================================
  Files          11       11           
  Lines         718      718           
=======================================
  Hits          311      311           
  Misses        369      369           
  Partials       38       38           
Flag Coverage Δ
unit 43.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@KevFan KevFan requested a review from a team August 11, 2023 14:35
Copy link
Member

@adam-cattermole adam-cattermole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, pulls the pinned version of yq.

We'll have to mirror this behaviour in https://github.com/Kuadrant/authorino-operator/blob/main/Makefile#L107-L109

@KevFan KevFan merged commit e110bb7 into Kuadrant:main Aug 11, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working participation/good first issue Good for newcomers size/small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

workflow: github.com/mikefarah/yq/v4@latest requires go1.20
4 participants