Parallel io additions #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es obj as return value for later
laurentheirendt
suggested changes
Jan 22, 2020
src/satellites.jl
Outdated
| end | ||
|
|
||
| # Statically split range [1,N] into equal sized chunks for np processors | ||
| function splitrange(N::Int, np::Int) |
There was a problem hiding this comment.
can you add a more extensive documentation here?
There was a problem hiding this comment.
I would appreciate if you could do this, don't know exactly what you did
There was a problem hiding this comment.
I didn't write the splitrange function. Can you combine it with the splitting function?
Codecov Report
@@ Coverage Diff @@
## develop #83 +/- ##
==========================================
+ Coverage 89.41% 89.72% +0.3%
==========================================
Files 8 8
Lines 586 613 +27
==========================================
+ Hits 524 550 +26
- Misses 62 63 +1
Continue to review full report at Codecov.
|
laurentheirendt
approved these changes
Jan 24, 2020
|
Thanks @oHunewald 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.