Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use rule.variable instead of rule.id in seemsdefined #222

Merged
merged 1 commit into from
Jul 17, 2022
Merged

use rule.variable instead of rule.id in seemsdefined #222

merged 1 commit into from
Jul 17, 2022

Conversation

paulflang
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Jul 15, 2022 •
edited
Loading

Codecov Report

Merging #222 (fe1b3b2) into master (378a658) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #222   +/-   ##
=======================================
  Coverage   93.76%   93.76%           
=======================================
  Files          10       10           
  Lines         754      754           
=======================================
  Hits          707      707           
  Misses         47       47
Impacted Files Coverage Δ
src/utils.jl 86.95% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 378a658...fe1b3b2. Read the comment docs.

@paulflang paulflang marked this pull request as ready for review July 15, 2022 21:40
@paulflang paulflang requested a review from exaexa July 15, 2022 21:40
@paulflang paulflang mentioned this pull request Jul 15, 2022
Merged
exaexa
exaexa approved these changes Jul 17, 2022
View reviewed changes
Copy link
Collaborator

@exaexa exaexa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, thanks!

@exaexa exaexa merged commit 8705bd1 into LCSB-BioCore:master Jul 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@exaexa exaexa exaexa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulflang @exaexa