-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use the safer Object_createChild SBML methods. #225
Conversation
This depends on sbmlteam/libsbml#252 to be merged, because some of the functions were actually not exposed to the C API. Creating the members from the parent objects seems safer because all XML metadata and versioning info gets automatically propagated. Also the code is a bit shorter.
(PS. obviously this won't work until the linked patch is in SBML_jll. :D ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree this pattern is a bit better, when it can be used 👍
Codecov Report
@@ Coverage Diff @@
## master #225 +/- ##
==========================================
- Coverage 93.76% 93.68% -0.09%
==========================================
Files 10 10
Lines 754 728 -26
==========================================
- Hits 707 682 -25
+ Misses 47 46 -1
Continue to review full report at Codecov.
|
Patchdozer disagrees. This will be used everywhere. :D |
This PR also removes all uses of Lines 4 to 7 in 9577bc1
apart from where we get the URI of the fbc extension Lines 760 to 768 in 9577bc1
which sounds a good improvement in terms of consistency! |
Yeah that was the point. I kindof hope we'll eventually be able to spew out e.g. SBML L2V4 by just specifying the correct version and not filling in anything L3-specific into the sbml structure. |
now depends on JuliaPackaging/Yggdrasil#5224 |
This depends on sbmlteam/libsbml#252 to be merged,
because some of the functions were actually not exposed to the C API.
Creating the members from the parent objects seems safer because all XML
metadata and versioning info gets automatically propagated. Also the code is a
bit shorter.