experiment class for laghos #362
Conversation
| description='number of serial refinements', | ||
| workloads=['laghos']) | ||
|
|
||
| workload_variable('rp', default='0', |
There was a problem hiding this comment.
Let's keep this "example" default at what it was before so default value should be 5, since we can pass in different values now via the scaling variants in experiment.
repo/laghos/application.py
Outdated
| workload_variable('rp', default='0', | ||
| description='number of parallel refinements', | ||
| workloads=['laghos']) | ||
| workload_variable('ms', default='4', |
There was a problem hiding this comment.
Likewise let's update this default value back to 500
| def compute_applications_section(self): | ||
| variables = {} | ||
|
|
||
| if self.spec.satisfies("scaling=weak"): |
There was a problem hiding this comment.
Let's start with the scaling assuming a single node, but change problem size per rank instead, once we know we have this right we can add more nodes or make updates. So for weak scaling:
rs values: 1
num processes: 8
rp values (increases workload per rank): 1,2,3,4
Another option if you can also implement this is rs values 1,2,3 and mpi processes 1,8,64
| variables["rs"] = ["5","6"] | ||
| variables["n_nodes"] = ["1","8"] | ||
| elif self.spec.satisfies("scaling=strong"): | ||
| variables["n_nodes"] = ["1","8"] |
There was a problem hiding this comment.
Instead of increasing nodes for strong scaling let's keep it on one node and increase MPI ranks, 1,8,64. We should lower the rs value to 1 or 2 here as well, depending on how long this takes to solve, these would ideally be less than 5 minutes to solve.
| variables["rs"] = "5" | ||
| else: | ||
| variables["n_nodes"] = ["1","2","4","8","16","32","64","128"] | ||
| variables["n_ranks"] = "{sys_cores_per_node} * {n_nodes}" |
There was a problem hiding this comment.
Since we're setting ranks explicitly above let's move both n_nodes and n_ranks into the else, and set this to one node, 8 ranks since this will be for the example run.
| "problem": { | ||
| #"variables": variables, | ||
| "experiments": { | ||
| "laghos_{n_nodes}_{n_ranks}": { |
There was a problem hiding this comment.
Can you add the other parameters into the naming scheme here, so basically anything that gets passed in (rs, rp, etc) should be in here, see the naming for the kripke experiment in https://github.com/LLNL/benchpark/pull/344/files
There was a problem hiding this comment.
@august-knox I enabled a dry-run test and it is failing. Please diagnose/fix.
pearce8
added
ci
bin/benchpark experiment init --dest laghos
Don't believe there's any variants that need to be specified here