Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes common formatting issues messing with CI #130

Merged
merged 1 commit into from
May 24, 2024
Merged

Fixes common formatting issues messing with CI #130

merged 1 commit into from
May 24, 2024

Conversation

ilumsden
Copy link
Collaborator

Now that our minimum supported version of Python is not 2.7 and now that we are using Python 3.9 for black and flake8 in CI, there are a couple of common things that are causing the black and flake8 checks to fail. This PR fixes them

@ilumsden ilumsden requested a review from pearce8 May 24, 2024 21:43
@ilumsden ilumsden self-assigned this May 24, 2024
@ilumsden ilumsden added area-ci Issues and PRs related to continuous integration processes used by Hatchet developers priority-normal Normal priority issues and PRs status-ready-for-review This PR is ready to be reviewed by assigned reviewers type-internal-cleanup PR or issues related to the structure of the codebase, directories and refactors type-style labels May 24, 2024
@ilumsden ilumsden added status-ready-to-merge This PR has made all revisions and is ready to merge into the develop branch and removed status-ready-for-review This PR is ready to be reviewed by assigned reviewers labels May 24, 2024
@pearce8 pearce8 merged commit 324e35b into LLNL:develop May 24, 2024
5 checks passed
@ilumsden ilumsden mentioned this pull request Jun 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pearce8 pearce8 pearce8 approved these changes

@michaelmckinsey1 michaelmckinsey1 michaelmckinsey1 approved these changes

Assignees

@ilumsden ilumsden

Labels
area-ci Issues and PRs related to continuous integration processes used by Hatchet developers priority-normal Normal priority issues and PRs status-ready-to-merge This PR has made all revisions and is ready to merge into the develop branch type-internal-cleanup PR or issues related to the structure of the codebase, directories and refactors type-style
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ilumsden @pearce8 @michaelmckinsey1