Add support for both row and column MultiIndex in dialects #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilumsden
added
area-query-lang
ilumsden
changed the title
ilumsden
force-pushed
the
new_style_query_support
branch
from
4b1f72b
to
faf80f4
Compare
ilumsden
force-pushed
the
new_style_query_support
branch
from
faf80f4
to
c2bb7d0
Compare
ilumsden
added
status-ready-for-review
slabasan
approved these changes
Apr 26, 2024
Yejashi
pushed a commit
to TauferLab/thicket
that referenced
this pull request
Apr 28, 2024
* Adds support for 'new-style' queries in Thicket * Adds unit test for MultiIndex column support in QL dialects * Allows "raw" string and object dialect queries to be used in Thicket.query * Adds license header and flake8 control comment to query.py * Restores the old "example_cali" pytest fixture as "simple_cali" * Updates unit tests to use the tip of develop for Hatchet * Changes new query tests to use rajaperf_seq_O3_1M_cali fixture * Adds ruff support in pyproject.toml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supersedes #44 and is linked to LLNL/hatchet#124
This PR adds support in Thicket for two features in Hatchet:
MultiIndexin the dialects (already in Hatchet)MultiIndexcolumns in the dialects (introduced by Adds support for multi-indexed column names hatchet#124)This PR should not be merged until both it and LLNL/hatchet#124 are ready to merge because this PR will be used to ensure the new "
MultiIndexcolumns" feature is actually working.