This repository has been archived by the owner on Feb 7, 2022. It is now read-only.
Added Root Options #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added options for expanding the root and displaying the the root label
|
Hi, thank you for the contribution! Looking at the diff, there are a few non-critical things that I'd like to discuss. |
|
|
||
| #### props.rootExpanded | ||
|
|
||
| Optional boolean to expand the root object. Defaults to true. |
There was a problem hiding this comment.
Not sure about this option, since there already exists a isExpanded predicate, I would like to rework it to be applied to root node as well. What do you think?
There was a problem hiding this comment.
Hi,
That sounds great. It didn't occur to me to update the existing isExpanded predicate.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added options for expanding the root and displaying the the root label