Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Leaflet 1.1.0+ #835

Closed
rkatka opened this issue Oct 30, 2017 · 3 comments
Closed

Add support for Leaflet 1.1.0+ #835

rkatka opened this issue Oct 30, 2017 · 3 comments

Comments

@rkatka
Copy link

rkatka commented Oct 30, 2017

Leaflet version 1.1.0 added ES6 and Rollup that made all leaflet objects non-extendable. This results in the current version of Leaflet.markercluster (1.1.0) no longer being compatible with the latest versions of Leaflet.

@danzel
Copy link
Member

danzel commented Oct 31, 2017

Ah dumb.
I think there is a plugin upgrade somewhere? Someone wanna find and link it please.
I'm pretty busy with other things ATM, so hoping someone else can pick this up. 🙏

@ghybs
Copy link
Contributor

ghybs commented Oct 31, 2017

Hi @rkatka,

While you are absolutely right that Leaflet 1.1.0 introduced a compatibility bug for plugins that need to extend some base objects (like L.Util and L.DomUtil), I do not recall such extension requirements in Leaflet.markercluster?

A quick test shows no particular issue: (Leaflet 1.1.0 + Leaflet.markercluster 1.1.0)
https://plnkr.co/edit/4xjaKXfBk6AnSY0Q388w?p=preview

That being said, if you can just upgrade to Leaflet 1.2.0, the above mentioned bug has been resolved.

@danzel
Copy link
Member

danzel commented Feb 6, 2018

This has been fixed since.

@danzel danzel closed this as completed Feb 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants