Fix non-extendable objects regression of 1.1.0 #5658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this hack makes Phantom go crazy. Not sure how to fix the tests... |
|
OK the tests seem to be running OK! Had to upgrade the Node version on Travis after some deps upgrades because of some compatibility bugs. |
perliedman
approved these changes
Jul 26, 2017
Closes #5650 until we figure out a less hacky solution.
4 tasks
|
This is breaking in an environment where Update: Maybe wrapping it in a try-catch would help. Update: PR #6806 created |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5650 until we figure out a less hacky solution. Tested it locally and it seems to work. I put the redefine in
Utilbecause it is currently included first in the Rollup build, but this is fragile. The advantage of this solution is that it changes just a few lines of code. cc @calvinmetcalf @perliedman @IvanSanchez