Robust array type check for cross-frame support #1279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a multi-frame DOM environment, if setView is called with an array for the first parameter, a subsequent call to getBounds raises "Invalid LatLng object" exception. This is the case if the array passed to setView was created outside the iFrame that contains the map. It causes the array test using "instanceof" in L.latLng to fail, and _initialTopLeftPoint to not being properly initialized. Thank you to Juriy Zaytsev for the full explaination: http://perfectionkills.com/instanceof-considered-harmful-or-how-to-write-a-robust-isarray/ John Resig and Dean Edwards post comments and concur.
mourner
added a commit
that referenced
this pull request
Jan 14, 2013
Robust array type check for cross-frame support
|
Sounds reasonable, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a multi-frame DOM environment, if setView is called with an array for
the first parameter, a subsequent call to getBounds raises "Invalid
LatLng object" exception. This is the case if the array passed to
setView was created outside the iFrame that contains the map. It causes
the array test using "instanceof" in L.latLng to fail, and
_initialTopLeftPoint to not being properly initialized.
Thank you to Juriy Zaytsev for the full explaination:
http://perfectionkills.com/instanceof-considered-harmful-or-how-to-write-a-robust-isarray/
John Resig and Dean Edwards post comments and concur.