fixing this._times.length undefined in Map.Drag.js, fixes #4311 #4324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -77,10 +79,6 @@ L.Map.Drag = L.Handler.extend({ | |||
| .fire('movestart') | |||
| .fire('dragstart'); | |||
|
|
|||
| if (map.options.inertia) { | |||
| this._positions = []; | |||
| this._times = []; | |||
There was a problem hiding this comment.
Why remove the initialization in _onDragStart? If inertia is enabled, we want to forget the speed of the previous drag(s) whenever a new drag is started; so we want to keep this bit of code.
There was a problem hiding this comment.
Sorry, my bad, i'm updating it right now.
|
Looks good now, but please squash your commits into one. For very small features/bugfixes such as this one we prefer to have just one commit. |
Update Map.Drag.js Update Map.Drag.js
LucasMouraDeOliveira
force-pushed
the
drag-undefineds
branch
from
3d82fb0
to
5f7c2e0
Compare
|
👍 |
IvanSanchez
added a commit
that referenced
this pull request
Mar 15, 2016
fixing this._times.length undefined in Map.Drag.js, fixes #4311
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.