Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A11y fixes from #3210 #5092

Merged
merged 1 commit into from
Nov 12, 2016
Merged

A11y fixes from #3210 #5092

merged 1 commit into from
Nov 12, 2016

Conversation

patrickarlt
Copy link
Member

This implements a few basic fixes I suggested in #3210 (comment).

This should do 2 things:

  1. Add the standards based way to force screen readers to ignore images with role="presenation" in addition to an empty alt tag.
  2. Add proper ARIA role and label to Zoom buttons. This makes VoiceOver read them as "Zoom in - button" as opposed to "+ - link". I an not sure if this will improve JAWs as well but it should.

mourner
mourner approved these changes Nov 12, 2016
View reviewed changes
Copy link
Member

@mourner mourner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. 🚢

@mourner mourner merged commit ab31976 into Leaflet:master Nov 12, 2016
DiogoMCampos pushed a commit to DiogoMCampos/Leaflet that referenced this pull request Dec 18, 2016
@patrickarlt @DiogoMCampos
A11y fixes from Leaflet#3210 (Leaflet#5092)
1e400d9
DiogoMCampos pushed a commit to DiogoMCampos/Leaflet that referenced this pull request Dec 18, 2016
@patrickarlt @DiogoMCampos
A11y fixes from Leaflet#3210 (Leaflet#5092)
00cceee
@Malvoz Malvoz added the accessibility Anything related to ensuring no barriers exist that prevent interactions or information access label Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mourner mourner mourner approved these changes

Assignees
No one assigned
Labels
accessibility Anything related to ensuring no barriers exist that prevent interactions or information access
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@patrickarlt @mourner @Malvoz