Updated Cards to v10.291. #2370
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Foundry-Developers/foundry-vtt-types into v10/non-inferring-data-fields_client_data_documents_cards
kmoschcau
requested changes
Jun 25, 2023
| | ConstructorDataType<foundry.data.CardsData> | ||
| | (ConstructorDataType<foundry.data.CardsData> & Record<string, unknown>) | ||
| >, | ||
| data: Array<ConstructorDataType<CardsData> | (ConstructorDataType<CardsData> & Record<string, unknown>)>, |
There was a problem hiding this comment.
This can probably be simplified even more, by using BaseCards.ConstructorData. We would then either need to introduce a generic parameter on the Cards class for the different system types or leave it open and add a union of all known types as a default to the ConstructorData. I think once we are done, we won't need ConstructorDataType at all anymore.
The same goes for the other occurrences. We can check each time whether it's ConstructorData, UpdateData or Properties.
There was a problem hiding this comment.
With that said, should I take further action for this PR?
…Foundry-Developers/foundry-vtt-types into v10/non-inferring-data-fields_client_data_documents_cards
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1955