common.utils.colors #2623
Merged
common.utils.colors #2623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JPMeehan
requested changes
Jul 10, 2024
src/foundry/common/utils/color.d.mts
Outdated
| /** | ||
| * The color represented as a linear RGB array. | ||
| * Assumes r, g, and b are contained in the set [0, 1] and returns linear r, g, and b in the set [0, 1]. | ||
| * @link https://en.wikipedia.org/wiki/SRGB#Transformation |
There was a problem hiding this comment.
Links must be wrapped in brackets {}
src/foundry/common/utils/color.d.mts
Outdated
| /** | ||
| * Create a Color instance (sRGB) from a linear rgb array. | ||
| * Assumes r, g, and b are contained in the set [0, 1]. | ||
| * @link https://en.wikipedia.org/wiki/SRGB#Transformation |
There was a problem hiding this comment.
Links must be wrapped in brackets {}
JPMeehan
approved these changes
Jul 11, 2024
JPMeehan
merged commit 83ace45
into
League-of-Foundry-Developers:v12/main
1 of 3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #2602
Would have loved to type the numeric values in the various array types to be [0..1], but unfortunately, it's not that simple.