Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unfiltered EIP-712 fallback to raw message for NBGL devices + skip button #652

Merged
merged 5 commits into from
Sep 24, 2024

Conversation

apaillier-ledger
Copy link
Contributor

@apaillier-ledger apaillier-ledger commented Sep 24, 2024

Description

Changes default behavior for unfiltered EIP-712 reviews for Flex & Stax, adds a skip button.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

if (N_storage.verbose_eip712 || (path_get_root_type() == ROOT_DOMAIN)) {
#endif
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor, but usually simpler to write:

#ifndef SCREEN_SIZE_WALLET
        if (N_storage.verbose_eip712 || (path_get_root_type() == ROOT_DOMAIN)) {
#endif
        {
                ...
        }

@apaillier-ledger apaillier-ledger merged commit 59d1a54 into develop Sep 24, 2024
154 of 155 checks passed
@apaillier-ledger apaillier-ledger deleted the feat/apa/eip712_skip branch September 24, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants