Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass account to asset page #7882

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

fix: pass account to asset page #7882

wants to merge 4 commits into from

Conversation

kallen-ledger
Copy link
Contributor

@kallen-ledger kallen-ledger commented Sep 24, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

  • pass defaultAccount to swap page from portfolio asset page
  • swap from for analytics of from location in swap live app

❓ Context

https://ledgerhq.atlassian.net/browse/LIVE-9213


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Sep 24, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Sep 24, 2024 0:43am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Sep 24, 2024 0:43am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Sep 24, 2024 0:43am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Sep 24, 2024 0:43am
web-tools ⬜️ Ignored (Inspect) Visit Preview Sep 24, 2024 0:43am

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Sep 24, 2024
@kallen-ledger kallen-ledger marked this pull request as ready for review September 24, 2024 10:56
@kallen-ledger kallen-ledger requested review from a team as code owners September 24, 2024 10:56
@@ -270,6 +279,10 @@ const SwapWebView = ({ manifest, liveAppUnavailable }: SwapWebProps) => {
[],
);

useEffect(() => {
console.log("xxxx", state);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

100% 🀭

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants