Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LIVE-14029 evm importer limiting to top 100 tokens by chains #7903

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

LIVE-14029 evm importer limiting to top 100 tokens by chains #7903

wants to merge 9 commits into from
+1,680 −71

Conversation

Wozacosta
Copy link
Contributor

@Wozacosta Wozacosta commented Sep 25, 2024 •
edited
Loading

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

all chains, no filtering:
image
evm only, no filtering by top 100:
image

evm only, filtering by top:

image

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@vercel Vercel
Copy link

vercel bot commented Sep 25, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-tools ❌ Failed (Inspect) Sep 28, 2024 6:15am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Sep 28, 2024 6:15am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Sep 28, 2024 6:15am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Sep 28, 2024 6:15am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Sep 28, 2024 6:15am

@live-github-bot live-github-bot bot added the ledgerjs Has changes in the ledgerjs open source libs label Sep 25, 2024
@Wozacosta Wozacosta changed the title working importer limiting to top100 tokens by chains LIVE-14029 working importer limiting to top100 tokens by chains Sep 25, 2024
@Wozacosta Wozacosta force-pushed the feat/lightweight-evm-signatures branch from 1da95f7 to e40dcab Compare September 26, 2024 13:38
@Wozacosta Wozacosta changed the title LIVE-14029 working importer limiting to top100 tokens by chains LIVE-14029 evm importer limiting to top 100 tokens by chains Sep 27, 2024
@Wozacosta Wozacosta marked this pull request as ready for review September 27, 2024 10:03
@Wozacosta Wozacosta requested a review from a team as a code owner September 27, 2024 10:03
@Wozacosta Wozacosta force-pushed the feat/lightweight-evm-signatures branch from 698e9a6 to 5e7a870 Compare September 27, 2024 10:05
lambertkevin
lambertkevin reviewed Sep 27, 2024
View reviewed changes
Copy link
Contributor

@lambertkevin lambertkevin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a bunch of (I think) useless files you can remove from the lib as they will not be consumed by anyone !
Also, I think you need to update evm-tools to consumed the EIP712 files and this new library instead of the normal cryptoassets otherwise it would still be a peer dependency of a peer dependency

libs/ledgerjs/packages/cryptoassets-evm-signatures/src/currencies.ts Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably unnecessary to have this file in the new lib

libs/ledgerjs/packages/cryptoassets-evm-signatures/src/currencies.test.ts Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably unnecessary to have this file in the new lib

libs/ledgerjs/packages/cryptoassets-evm-signatures/src/abandonseed.ts Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably unnecessary to have this file in the new lib

libs/ledgerjs/packages/cryptoassets-evm-signatures/src/__snapshots__/currencies.test.ts.snap Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably unnecessary to have this file in the new lib

libs/ledgerjs/packages/cryptoassets-evm-signatures/README.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can probably be removed as well, documentation for such lib seems unnecessary

libs/ledgerjs/packages/cryptoassets-evm-signatures/package.json Outdated
"build": "tsc && tsc -m ES6 --outDir lib-es",
"prewatch": "pnpm build",
"watch": "tsc --watch",
"doc": "documentation readme src/** --section=API --pe ts --re ts --re d.ts",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd remove the doc script to prevent painful forgotten commits about this for no reason if I were you

@Wozacosta Wozacosta requested a review from a team as a code owner September 27, 2024 14:35
@live-github-bot live-github-bot bot added the common Has changes in live-common label Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lambertkevin lambertkevin lambertkevin left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@Wozacosta Wozacosta

Labels
common Has changes in live-common ledgerjs Has changes in the ledgerjs open source libs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Wozacosta @lambertkevin