[QAA-168] Adding new send test cases #7938
Open
+17,952
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 5 Skipped Deployments
|
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
| @@ -39,9 +40,18 @@ export class SendModal extends Modal { | |||
| await this.recipientInput.fill(recipient); | |||
| } | |||
|
|
|||
| @step("Enter recipient as $0") | |||
There was a problem hiding this comment.
"$0" will be displayed as Object object in report because transaction is not a string
| } | ||
|
|
||
| for (const transaction of transactionsAddressInvalid) { | ||
| test.describe("Send funds setp 1 (Recipient) - negative cases (Button disabled)", () => { |
| @@ -314,3 +417,63 @@ test.describe("Verify send max user flow", () => { | |||
| }, | |||
| ); | |||
| }); | |||
|
|
|||
| for (const transaction of transactionAddressValid) { | |||
| test.describe("Send funds step 1 (Recipient) - positive cases (Button enabled)", () => { | |||
There was a problem hiding this comment.
I think this should be a part of full e2e scenario where we actually send funds (even if without broadcasting) because creating test just for one check that button is enabled is an overkill
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
Adding new send test scénarios:
CI Run: https://github.com/LedgerHQ/ledger-live/actions/runs/11069828999 (fail = getAppAndVersion)
❓ Context
🧐 Checklist for the PR Reviewers