Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 🗺️ fix IDE go to definition feature for some libs #7941

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

thesan
Copy link
Contributor

@thesan thesan commented Sep 27, 2024

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Add declaration map on dependencies where they are missing. It allows quickly checking the references definitions on IDEs.
I was exploring the code base a bit for tech day, and realised the declaration maps where missing for some packages (mostly the design system related dependencies.

Before:

Screen.Recording.2024-09-27.at.13.01.44.mov

After:

Screen.Recording.2024-09-27.at.13.19.19.mov

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@thesan thesan requested a review from a team as a code owner September 27, 2024 11:18
Copy link

vercel bot commented Sep 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Sep 27, 2024 11:18am
ledger-live-github-bot ⬜️ Ignored (Inspect) Sep 27, 2024 11:18am
native-ui-storybook ⬜️ Ignored (Inspect) Sep 27, 2024 11:18am
react-ui-storybook ⬜️ Ignored (Inspect) Sep 27, 2024 11:18am
web-tools ⬜️ Ignored (Inspect) Sep 27, 2024 11:18am

@live-github-bot live-github-bot bot added the ui Has changes in the design system library label Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui Has changes in the design system library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants