Fix monitor sorting with mix of portrait and landscape layout. #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks fine to me and Travis, I didn't double check everything but the = is redundant in one of the two comparisons. |
|
Ah, you're right - I believe it's the latter, but will test when home today to be safe. |
neeasade
force-pushed
the
monitor_sort
branch
from
a5597f7
to
7f8a791
Compare
|
Removed second =, retested with the three monitor layouts, seems okay to me. Used |
LemonBoy
added a commit
that referenced
this pull request
Oct 21, 2015
Fix monitor sorting with mix of portrait and landscape layout.
|
Aaand merged! Thank you for the PR :) |
Closed
|
np, thank you for the flexible program. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes monitor sorting to keep sorting by x and y coordinates, but also takes into account a height comparison that I believe fixes sorting in currently unexpected monitor situations. This is done in a way that keeps current monitor sorting the same on setups with the y offset aligned across the top, so impact should be minimal.
This includes #118
Notes for how I got here and screenshots along the way are attached to #147 (It's unorganized as I commented as I went along) - this was tested in 3 different monitor layouts with different geometry spawns, as seen there.