Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: move CheckEndCallback to Iterator #690

Merged
merged 1 commit into from
Dec 7, 2019
Merged

Conversation

vweevers
Copy link
Member

No description provided.

@vweevers vweevers added semver-patch Bug fixes that are backward compatible refactor Requires or pertains to refactoring labels Oct 21, 2019
@ralphtheninja ralphtheninja removed their request for review October 27, 2019 18:48
@vweevers
Copy link
Member Author

@peakji Do you have time to review?

@peakji
Copy link
Member

peakji commented Nov 29, 2019

@peakji Do you have time to review?

I’m afraid I won’t have time right now (and the next couple of weeks). Sorry! 😅

Copy link
Member

@ralphtheninja ralphtheninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some mental bandwidth now. Looks good! (My own TODO?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Requires or pertains to refactoring semver-patch Bug fixes that are backward compatible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants