Restore Windows 32-bit prebuild #711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds 194kb (or 406kb unpacked) to our npm package size. Previously removed because only 2% of installs were on 32-bit Windows and we agreed those users could compile from source. However, there is currently a gap in electron(-builder) tooling when used on native addons that use node-gyp-build: these addons don't get automatically recompiled. Though we don't need that anymore for runtimes (the builds are compatible with both node and electron) our users do need it when targeting multiple CPU architectures. Ref digidem/mapeo-desktop#305 Ref electron-userland/electron-builder#4370 Ref #554
|
Ignore the FreeBSD failure, that's an issue with node, not leveldown, see #708 (comment). |
|
Great thanks so much, this is going to be really helpful for us electron users |
7 tasks
|
5.6.0 |
|
yay thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds 194kb (or 406kb unpacked) to our npm package size.
Previously removed because only 2% of installs were on 32-bit Windows and we agreed those users could compile from source.
However, there is currently a gap in
electron(-builder)tooling when used on native addons that usenode-gyp-build: these addons don't get automatically recompiled *. Though we don't need that anymore for runtimes (the builds are compatible with both node and electron) our users do need it when targeting multiple CPU architectures.* Or not always recompiled, I'm not sure. I don't have enough time to investigate further.
Ref digidem/mapeo-desktop#305
Ref electron-userland/electron-builder#4370
Ref #554