Add Entry struct to abstract away key-value pairs #785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "blockRestartInterval", 16); | ||
| uint32_t maxFileSize = Uint32Property(env, options, "maxFileSize", 2 << 20); | ||
| const uint32_t maxFileSize = Uint32Property(env, options, "maxFileSize", 2 << 20); |
There was a problem hiding this comment.
const ❤️ Good thinking. Very good practice in c++ to use const as much as possible.
15 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small thing. Prep work that will reduce the amount of code needed for
all()andgetMany()(Level/abstract-leveldown#380).Has no impact on performance.