Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): update onnxruntime requirement from <1.19,>=1.12.0 to >=1.12.0,<1.20 in /requirements #2692

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 19, 2024

Updates the requirements on onnxruntime to permit the latest version.

Release notes

Sourced from onnxruntime's releases.

ONNX Runtime v1.19

Announcements

  • Note that Java (maven) and training (pypi) packages are delayed from package manager release due to some publishing errors. Feel free to contact @​maanavd if you need release candidates for some workflows ASAP. In the meantime, binaries are attached to this post. This message will be deleted once this ceases to be the case. Thanks for your understanding :)
  • Second note that the wrong commit was initially tagged with v1.19.0. The final commit has since been correctly tagged: microsoft/onnxruntime@26250ae. This shouldn't effect much, but sorry for the inconvenience!

Build System & Packages

  • Numpy support for 2.x has been added
  • Qualcomm SDK has been upgraded to 2.25
  • ONNX has been upgraded from 1.16 → 1.16.1
  • Default GPU packages use CUDA 12.x and Cudnn 8.x (previously CUDA 11.x/CuDNN 8.x) CUDA 11.x/CuDNN 8.x packages are moved to the aiinfra VS feed.
  • TensorRT 10.2 support added
  • Introduced Java CUDA 12 packages on Maven.
  • Discontinued support for Xamarin. (Xamarin reached EOL on May 1, 2024)
  • Discontinued support for macOS 11 and increasing the minimum supported macOS version to 12. (macOS 11 reached EOL in September 2023)
  • Discontinued support for iOS 12 and increasing the minimum supported iOS version to 13.

Core

  • Implemented DeformConv

Performance

  • Added QDQ support for INT4 quantization in CPU and CUDA Execution Providers
  • Implemented FlashAttention on CPU to improve performance for GenAI prompt cases
  • Improved INT4 performance on CPU (X64, ARM64) and NVIDIA GPUs

Execution Providers

  • TensorRT

    • Updated to support TensorRT 10.2
    • Remove calls to deprecated api’s
    • Enable refittable embedded engine when ONNX model provided as byte stream
  • CUDA

    • Added support for building with CUDA 12.5.
    • Upgraded cutlass to 3.5.0 for performance improvement of memory efficient attention.
    • Updated MultiHeadAttention and Attention operators to be thread-safe.
    • Added sdpa_kernel provider option to choose kernel for Scaled Dot-Product Attention.
    • Expanded op support - Tile (bf16)
  • CPU

    • Expanded op support - GroupQueryAttention, SparseAttention (for Phi-3 small)
  • QNN

    • Updated to support QNN SDK 2.25
    • Expanded op support - HardSigmoid, ConvTranspose 3d, Clip (int32 data), Matmul (int4 weights), Conv (int4 weights), prelu (fp16)
    • Expanded fusion support – Conv + Clip/Relu fusion
  • OpenVINO

    • Added support for OpenVINO 2024.3
    • Support for enabling EpContext using session options
  • DirectML

... (truncated)

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

📚 Documentation preview 📚: https://torchmetrics--2692.org.readthedocs.build/en/2692/

@dependabot dependabot bot requested a review from SkafteNicki as a code owner August 19, 2024 23:31
@dependabot dependabot bot added the test / CI testing or CI label Aug 19, 2024
@dependabot dependabot bot requested a review from a team August 19, 2024 23:31
@dependabot dependabot bot force-pushed the dependabot-pip-requirements-onnxruntime-gte-1.12.0-and-lt-1.20 branch 2 times, most recently from 6b5b16a to 7383543 Compare August 20, 2024 15:35
@Borda
Copy link
Member

Borda commented Aug 20, 2024

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot-pip-requirements-onnxruntime-gte-1.12.0-and-lt-1.20 branch from 7383543 to 230d7fc Compare August 20, 2024 15:36
@mergify mergify bot added the ready label Aug 20, 2024
@Borda
Copy link
Member

Borda commented Aug 21, 2024

this seems to be similar: facebookresearch/svoice#97

@dependabot dependabot bot force-pushed the dependabot-pip-requirements-onnxruntime-gte-1.12.0-and-lt-1.20 branch from 230d7fc to 513a2a9 Compare August 27, 2024 06:33
Updates the requirements on [onnxruntime](https://github.com/microsoft/onnxruntime) to permit the latest version.
- [Release notes](https://github.com/microsoft/onnxruntime/releases)
- [Changelog](https://github.com/microsoft/onnxruntime/blob/main/docs/ReleaseManagement.md)
- [Commits](microsoft/onnxruntime@v1.12.0...v1.19.0)

---
updated-dependencies:
- dependency-name: onnxruntime
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot-pip-requirements-onnxruntime-gte-1.12.0-and-lt-1.20 branch from 513a2a9 to 470562b Compare August 27, 2024 07:39
@mergify mergify bot removed the ready label Aug 27, 2024
@SkafteNicki
Copy link
Member

Lets try to bump numpy as it seems to be partial solution

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69%. Comparing base (0313c6b) to head (7d2201f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #2692   +/-   ##
======================================
  Coverage      69%     69%           
======================================
  Files         316     316           
  Lines       17900   17900           
======================================
  Hits        12328   12328           
  Misses       5572    5572           

@mergify mergify bot added the ready label Aug 28, 2024
@SkafteNicki
Copy link
Member

So the problem seems to be with the pesq package with complains that it is compiled against numpy<2.0. So currently docs are failing because numpy>=2.0 is being used there.

requirements/base.txt Outdated Show resolved Hide resolved
requirements/base.txt Outdated Show resolved Hide resolved
@Borda
Copy link
Member

Borda commented Sep 2, 2024

So the problem seems to be with the pesq package with complains that it is compiled against numpy<2.0. So currently docs are failing because numpy>=2.0 is being used there.

reporting it in ludlows/PESQ#54

@Borda Borda merged commit 35eb342 into master Sep 2, 2024
70 checks passed
@Borda Borda deleted the dependabot-pip-requirements-onnxruntime-gte-1.12.0-and-lt-1.20 branch September 2, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready test / CI testing or CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants