Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): update nltk requirement from <=3.8.1,>=3.6 to >=3.6,<=3.9.1 in /requirements #2693

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 19, 2024

Updates the requirements on nltk to permit the latest version.

Changelog

Sourced from nltk's changelog.

Version 3.9.1 2024-08-19

  • Fixed bug that prevented wordnet from loading

Version 3.9 2024-08-18

  • Avoid need for pickled models, resolves security vulnerability CVE-2024-39705
  • No longer sort WordNet synsets and relations (sort in calling function when required)
  • Add Python 3.12 support
  • Many other minor fixes

Thanks to the following contributors to 3.8.2: Tom Aarsen, Cat Lee Ball, Veralara Bernhard, Carlos Brandt, Konstantin Chernyshev, Michael Higgins, Eric Kafe, Vivek Kalyan, David Lukes, Rob Malouf, purificant, Alex Rudnick, Liling Tan, Akihiro Yamazaki.

Version 3.8.1 2023-01-02

  • Resolve RCE vulnerability in localhost WordNet Browser (#3100)
  • Remove unused tool scripts (#3099)
  • Resolve XSS vulnerability in localhost WordNet Browser (#3096)
  • Add Python 3.11 support (#3090)

Thanks to the following contributors to 3.8.1: Francis Bond, John Vandenberg, Tom Aarsen

Version 3.8 2022-12-12

  • Refactor dispersion plot (#3082)
  • Provide type hints for LazyCorpusLoader variables (#3081)
  • Throw warning when LanguageModel is initialized with incorrect vocabulary (#3080)
  • Fix WordNet's all_synsets() function (#3078)
  • Resolve TreebankWordDetokenizer inconsistency with end-of-string contractions (#3070)
  • Support both iso639-3 codes and BCP-47 language tags (#3060)
  • Avoid DeprecationWarning in Regexp tokenizer (#3055)
  • Fix many doctests, add doctests to CI (#3054, #3050, #3048)
  • Fix bool field not being read in VerbNet (#3044)
  • Greatly improve time efficiency of SyllableTokenizer when tokenizing numbers (#3042)
  • Fix encodings of Polish udhr corpus reader (#3038)
  • Allow TweetTokenizer to tokenize emoji flag sequences (#3034)
  • Prevent LazyModule from increasing the size of nltk.dict (#3033)
  • Fix CoreNLPServer non-default port issue (#3031)
  • Add "acion" suffix to the Spanish SnowballStemmer (#3030)
  • Allow loading WordNet without OMW (#3026)
  • Use input() in nltk.chat.chatbot() for Jupyter support (#3022)
  • Fix edit_distance_align() in distance.py (#3017)
  • Tackle performance and accuracy regression of sentence tokenizer since NLTK 3.6.6 (#3014)
  • Add the Iota operator to semantic logic (#3010)
  • Resolve critical errors in WordNet app (#3008)
  • Resolve critical error in CHILDES Corpus (#2998)
  • Make WordNet information_content() accept adjective satellites (#2995)
  • Add "strict=True" parameter to CoreNLP (#2993, #3043)
  • Resolve issue with WordNet's synset_from_sense_key (#2988)

... (truncated)

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

📚 Documentation preview 📚: https://torchmetrics--2693.org.readthedocs.build/en/2693/

@Borda
Copy link
Member

Borda commented Aug 20, 2024

the same issue as #2686 (comment)

@dependabot dependabot bot force-pushed the dependabot-pip-requirements-nltk-gte-3.6-and-lte-3.9.1 branch 2 times, most recently from 6e39c5c to 71bb9c7 Compare August 20, 2024 15:34
@Borda Borda marked this pull request as draft August 20, 2024 15:35
@dependabot dependabot bot force-pushed the dependabot-pip-requirements-nltk-gte-3.6-and-lte-3.9.1 branch 2 times, most recently from 81c6007 to 87e9dca Compare August 27, 2024 06:33
Updates the requirements on [nltk](https://github.com/nltk/nltk) to permit the latest version.
- [Changelog](https://github.com/nltk/nltk/blob/develop/ChangeLog)
- [Commits](nltk/nltk@3.6...3.9.1)

---
updated-dependencies:
- dependency-name: nltk
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot-pip-requirements-nltk-gte-3.6-and-lte-3.9.1 branch from 87e9dca to c663cc6 Compare August 27, 2024 07:40
@SkafteNicki SkafteNicki marked this pull request as ready for review August 27, 2024 09:37
@SkafteNicki
Copy link
Member

Updated minimum nltk to 3.8.2 as described in this issue: nltk/nltk#3293

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 39%. Comparing base (c3b8945) to head (903736e).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (c3b8945) and HEAD (903736e). Click for more details.

HEAD has 80 uploads less than BASE
Flag BASE (c3b8945) HEAD (903736e)
Windows 6 3
python3.8 6 3
cpu 40 20
torch1.13.1+cpu 6 3
torch2.4.0+cpu 2 1
python3.11 6 3
macOS 8 4
torch2.4.0 2 1
Linux 26 13
python3.9 18 9
torch1.10.2+cpu 2 1
torch2.0.1+cpu 6 3
python3.10 10 5
torch1.12.1+cpu 2 1
torch1.11.0+cpu 2 1
torch2.0.1 4 2
torch1.13.1 2 1
torch2.3.1+cpu 4 2
torch2.2.2+cpu 4 2
torch2.4.0+cu121 2 1
torch2.1.2+cpu 2 1
Additional details and impacted files
@@           Coverage Diff            @@
##           master   #2693     +/-   ##
========================================
- Coverage      69%     39%    -30%     
========================================
  Files         316     316             
  Lines       17745   17745             
========================================
- Hits        12193    6885   -5308     
- Misses       5552   10860   +5308     

@mergify mergify bot added the ready label Aug 28, 2024
@SkafteNicki SkafteNicki merged commit ef22554 into master Aug 28, 2024
70 checks passed
@SkafteNicki SkafteNicki deleted the dependabot-pip-requirements-nltk-gte-3.6-and-lte-3.9.1 branch August 28, 2024 08:41
Borda pushed a commit that referenced this pull request Sep 11, 2024
…9.1 in /requirements (#2693)

* build(deps): update nltk requirement in /requirements

Updates the requirements on [nltk](https://github.com/nltk/nltk) to permit the latest version.
- [Changelog](https://github.com/nltk/nltk/blob/develop/ChangeLog)
- [Commits](nltk/nltk@3.6...3.9.1)

---
updated-dependencies:
- dependency-name: nltk
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

* fix source

* update requirements

* skip flaky stuff

* skip more flaky stuff

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Nicki Skafte <skaftenicki@gmail.com>
(cherry picked from commit ef22554)
Borda pushed a commit that referenced this pull request Sep 13, 2024
…9.1 in /requirements (#2693)

* build(deps): update nltk requirement in /requirements

Updates the requirements on [nltk](https://github.com/nltk/nltk) to permit the latest version.
- [Changelog](https://github.com/nltk/nltk/blob/develop/ChangeLog)
- [Commits](nltk/nltk@3.6...3.9.1)

---
updated-dependencies:
- dependency-name: nltk
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

* fix source

* update requirements

* skip flaky stuff

* skip more flaky stuff

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Nicki Skafte <skaftenicki@gmail.com>
(cherry picked from commit ef22554)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants