xcodeproj_extensions: fix wrong serialization with local swift packages. #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashdnazg
approved these changes
Sep 15, 2024
lib/kintsugi/xcodeproj_extensions.rb
Outdated
| # The original implemenation is `" #{isa} \"#{File.basename(display_name)}\"` so that means that if we have a | ||
| # relative path which is Path/To/Package, the item will be serialized as `XCLocalSwiftPackageReference "Package"`. | ||
| # And Xcode will automatically fix this to be `XCLocalSwiftPackageReference "Path/To/Package"`. | ||
| # So, we need to patch the implementationa and make sure the whole path is used. |
There was a problem hiding this comment.
Suggested change
| # So, we need to patch the implementationa and make sure the whole path is used. | |
| # So, we need to patch the implementation and make sure the whole path is used. |
In case of a local Swift package, xcodeproj wrongfully uses the
`File.basename` of the path and Xcode fixes that to be the full path.
This commit patches the xcodeproj implementation and fixes it.
Below is an example before and after the change.
before (wrong):
/* Begin XCLocalSwiftPackageReference section */
BA78EB3B2C889B20000D85B2 /* XCLocalSwiftPackageReference "Package" */ = {
isa = XCLocalSwiftPackageReference;
relativePath = ../Path/To/Package;
};
after (correct)
/* Begin XCLocalSwiftPackageReference section */
BA78EB3B2C889B20000D85B2 /* XCLocalSwiftPackageReference "../Path/To/Package" */ = {
isa = XCLocalSwiftPackageReference;
relativePath = ../Path/To/Package;
};
barakwei
force-pushed
the
feature/fix-local-switch-package-path-serialization
branch
from
7e032d7
to
90117e1
Compare
barakwei
deleted the
feature/fix-local-switch-package-path-serialization
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of a local Swift package, xcodeproj wrongfully uses the
File.basenameof the path and Xcode fixes that to be the full path.This commit patches the xcodeproj implementation and fixes it.
Below is an example before and after the change.
before (wrong):
after (correct)