NSInvocation+OCMAdditions: don't retain deallocating objects. #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byohay
approved these changes
May 12, 2022
byohay
reviewed
May 15, 2022
| @@ -66,7 +66,8 @@ - (void)retainObjectArgumentsExcludingObject:(id)objectToExclude | |||
| NSMutableArray *retainedArguments = [[NSMutableArray alloc] init]; | |||
|
|
|||
| id target = [self target]; | |||
| if((target != nil) && (target != objectToExclude) && !object_isClass(target)) | |||
| if((target != nil) && (target != objectToExclude) && !object_isClass(target) && | |||
| [target allowsWeakReference]) | |||
There was a problem hiding this comment.
I'd add a comment as to why allowsWeakReference is needed.
Solves erikdoe#346. `allowsWeakReference` returns `NO` if the receiver is during deallocation. Not retaining deallocating objects would prevent crashing later when the retained arguments are released - including the previously deallocated objects. There are some classes that can never have weak references - these would also not be retained which might limit some OCMock functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves erikdoe#346.
allowsWeakReferencereturnsNOif the receiver is duringdeallocation. Not retaining deallocating objects would prevent crashing
later when the retained arguments are released - including the
previously deallocated objects.
There are some classes that can never have weak references - these would
also not be retained which might limit some OCMock functionality.